Gary,
Your code is functionally correct. Although it passes cstyle -pPc it
does not conform to the cstyle.ms.pdf
It is not your fault, it is a bug in cstyle.
Here are the cstyle nits:
line 952:
should be indented by a tab (it is aligned with the if clause)
line 953-963:
easier shown than describe... three options:
1.
} else switch (scf_error()) {
case ...
}
2.
} else switch (scf_error()) {
case ...
}
3.
} else {
switch (scf_error()) {
...
}
}
I didn't use tabs for indentation in the email, but that's what should
be used in the code.
I've found 1 and 2 in ON code and I assume both are valid.
Antonello
Gary Mills wrote:
>> Could you please make sure the code conforms with
>> cstyle as defined in
>>
>> http://opensolaris.org/os/community/documentation/gett
>> ing_started_docs/cstyle.ms.pdf
>>
>> and resubmit?
>>
>> You can make sure your code conforms with cstyle by
>> running
>>
>> hg cstyle <file>
>> if you have on SUNWonbld installed
>>
>> /opt/onbld/bin/cstyle -Ppc
>
> Wow, that was painful with emacs, but it now passes `cstyle -pPc'.
> I suppose I'll have to change my emacs macros that I haven't
> touched in years.
>
> My new webrev is now at:
>
> http://cr.opensolaris.org/~jgmills/testws/
>
> The bug is:
>
> 6383235 smf_maintain_instance() shouldn't fail with SCF_ERROR_DELETED
