It looks good to me. Antonello
Gary Mills wrote: >> Your code is functionally correct. Although it passes >> cstyle -pPc it >> does not conform to the cstyle.ms.pdf >> It is not your fault, it is a bug in cstyle. > > Thanks. I believe I've corrected it now. Once again, see: > > http://cr.opensolaris.org/~jgmills/testws/ > > This is for: > > 6383235 smf_maintain_instance() shouldn't fail with SCF_ERROR_DELETED > >> Here are the cstyle nits: >> >> line 952: >> should be indented by a tab (it is aligned with >> the if clause) >> >> line 953-963: >> easier shown than describe... three options: >> 1. >> } else switch (scf_error()) { >> case ... >> } >> 2. >> } else switch (scf_error()) { >> case ... >> 3. >> } else { >> switch (scf_error()) { >> ... >> } >> idn't use tabs for indentation in the email, but >> that's what should >> be used in the code. >> I've found 1 and 2 in ON code and I assume both are >> valid. > > I went with the third because it seems clearer.
