Liane Praza wrote: > Tony Nguyen wrote: >> I had a look at the files requested of me in the last round and a few >> additional simple ones. I plan to look at scf_tmpl.c and can review >> other files if the team feels necessary. > >> usr/src/cmd/svc/milestone/global.xml >> line 164: IMO, it'd be quite helpful to also list when an optional_all >> dependency isn't satisfied. > > Do you have suggestions about formulation that isn't "unsatisfied in all > other cases"? I'm not seeing a good one right now. > >> usr/src/cmd/svc/svcs/svcs.c >> 126 - 128: Nits, can these also be declared static for consistency? > > Sure, fixed.
Oh, wait. Can't change these -- they're externed and used in explain.c. The new one isn't and that's why it's different. Sorry. liane
