I had a look at the files requested of me in the last round and a few additional simple ones. I plan to look at scf_tmpl.c and can review other files if the team feels necessary.
I'm really excited about the improved usability and observability this project will deliver. -tony usr/src/cmd/svc/milestone/global.xml line 164: IMO, it'd be quite helpful to also list when an optional_all dependency isn't satisfied. usr/src/cmd/svc/svcs/svcs.c 126 - 128: Nits, can these also be declared static for consistency? The following files are OK. usr/src/cmd/svc/dtd/service_bundle.dtd.1 usr/src/lib/libscf/inc/libscf_priv.h usr/src/lib/libscf/Makefile.com usr/src/cmd/svc/milestone/Makefile usr/src/pkgdefs/SUNWcsr/prototype_com usr/src/lib/libscf/common/lowlevel.c usr/src/lib/libscf/common/mapfile-vers usr/src/lib/libscf/common/midlevel.c usr/src/cmd/svc/milestone/make-console-login-xml usr/src/tools/scripts/bfu.sh usr/src/lib/libuutil/common/uu_alloc.c