Quoth Antonello Cruz on Mon, Oct 13, 2008 at 03:37:40PM -0700:
> The dtd prevents importing a manifest with an empty string as type 
> attribute for a prop_pattern tag. If the type attribute is present, 
> svccfg will make sure it is one of the valid SCF_TYPE_* excluding 
> SCF_TYPE_INVALID, of course.

Ok.

> Basically what we are doing is if a property template exist (it has to 
> otherwise you wouldn't have a valid scf_prop_tmpl_t handle for it) and 
> type is not found, it means that type is wildcarded. It follows the 
> description of most SCF_ERROR_NOT_FOUND in templates: "property doesn't 
> exist or has no value".

I understand.  What I'm asking is whether you should be more strict in
the interpretation of the absence of the property.  Doing so brings the
benefit of alerting users when the property has been modified in an
unsupported manner.  Not doing so brings the benefit of allowing users
to modify the properties directly without your tools, and not having to
change the code if the import code changes in the future so that absence
of the attribute results in no property.  It seems you have chosen the
latter, which is ok.


David

Reply via email to