Hi David,
Thanks for the review.
see my comments inline.
David Bustos wrote:
> Quoth Erwann Chenede on Thu, Jun 12, 2008 at 08:02:37PM +0200:
>
>> you can now also browse the code via opengrok :
>> http://src.opensolaris.org/source/xref/jds/desktop-cache/trunk/
>>
>
> desktop-mime-cache/desktop-mime-cache
> - You use "/usr/share/application/mimeinfo.cache" a lot. I recommend
> using a shell variable instead.
>
done.
> 76: This will cause the script to run update-desktop-database. Is
> that correct?
>
Yes, if the no cache exist it creates it.
> 84: SMF_EXIT_MON_DEGRADE isn't documented in smf_method(5). Please
> choose another exit code.
>
Done, changed to SMF_EXIT_ERR_FATAL. I'll do all the other scripts
later. note fc-cache uses
this exit code too. What is the different between these 2 exit code ?
> desktop-mime-cache/desktop-mime-cache.xml
> 86: Would you mind including "MIME cache" in this description?
>
I've added a reference to the update-desktop-database manpage
> gconf-cache/gconf-cache
> 71: rval isn't set anywhere. Why are you using it?
>
Nope, I've removed it.
> 96,112: SMF_EXIT_MON_DEGRADE isn't documented in smf_method(5).
> Please choose another exit code.
>
done
Thanks,
Erwann
> I didn't look at the other files.
>
>
> David
> _______________________________________________
> pkg-discuss mailing list
> pkg-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
--
Erwann Ch?ned?,
Desktop Group, Sun Microsystems, Grenoble
