Hi Dave,
Thanks for the review !
see my comments inline.
Dave Miner wrote:
[...]
> Comments on manifests:
>
> Usual practice has been to create the SMF service instances as
> disabled by default and use the system profiles to enable them. I'm
> not clear on whether we're being militant about that these days, but
> if so there's a change in ON that goes along with this.
Who should I ask to confirm this ? I like the way this package isn't
dependent on anything other package for the moment.
>
> You've used the name "usr" for all of the filesystem/local
> dependencies, traditionally we'd use something more like "local" or
> "fs-local" to relate the dependency name more closely to the service
> FMRI. Usually I highly encourage comments with dependencies to record
> why we have them (these are fairly obvious, but...)
Done, I've changed usr to fs-local and added comments for all the
dependencies (fs-local and gdm).
>
> Evolving is an obsolete stability value. I presume you want
> Committed.
> http://www.opensolaris.org/os/community/arc/policies/interface-taxonomy/
I've changed it to Uncommitted as I'll wait the ARC discussion to change
it to committed.
Thanks,
Erwann
[...]
>
--
Erwann Ch?ned?,
Desktop Group, Sun Microsystems, Grenoble
Phone : +33 476 188 358 ext: 38358
