On Mon, Jun 23, 2008 at 05:05:13PM +0100, Alan Maguire wrote: > webrev at: > > http://cr.opensolaris.org/~amaguire/smf_ordered_values/ > > Additional testing revealed some additional changes > were needed beyond those described here: > > http://www.opensolaris.org/jive/thread.jspa?threadID=63250&tstart=0 > > Specifically, handling for nonglobal zones - where > the persistent repository is immediately writable - > and svccfg handling of multivalued properties on > import needed to be addressed also. The first issue > is solved by an additional upgrade check, the > second is solved by changing the uu_list svccfg > uses to store property values during import to > be ordered, rather than sorting it by strcmp()-based > comparison of values. > > I've tested this pretty thoroughly in global and > nonglobal zones, run the SMF test suite in > baseline, bfu-upgraded and bfu-downgraded > scenarios, and all tests pass as expected (though > a few tweaks to a few SMF suite testcases are needed > since they expect imported values to be in a > strcmp()-sorted order). I'll do some xVM testing > also - are there any other suggestions for test > scenarios beyond this and the bfu upgrade/downgrade > (with nonglobal zones configured and tested also) > testing mentioned above? Thanks! > > Alan
Alan -- Fantastic work and sorely needed: thanks for doing this. I looked it over and it looks good to me. One thing I would ask that you check is to write a trivial micro-benchmark for element get/set and make sure that the schema change hasn't encountered some unforeseen sqlite behavior where we have substantively regressed basic property r/w performance. I can't see why that would be, but it would be nice to check. Nice job, -Mike -- Mike Shapiro, Sun Microsystems Fishworks. blogs.sun.com/mws/
