Quoth Alan Maguire on Mon, Jun 23, 2008 at 05:05:13PM +0100:
> http://cr.opensolaris.org/~amaguire/smf_ordered_values/
cmd/svc/configd/backend.c
379: Please add that the variable is implicitly protected by
bes[BACKEND_TYPE_NORMAL]->be_lock .
1024-27: This duplicates the table definition at 267. Please note
this in the comment at 264.
1029: This duplicates the index definition at 301. Please note this
in a comment near 295.
1697: I don't understand why we would need to check whether the
database has been upgraded without upgrading it. Please explain it
to me.
2374: The code at 2360 detects non-global zone boot with
writeable_persist and an uninitialized nonpersistent repository. If
you are also trying to act only when a non-global zone is booted,
why don't you use the same test? And why don't you need the backend
to be locked like the code at 2363 does?
cmd/svc/configd/configd.c
391: I suspect we should always prepend "svc.configd: ", in case the
next programmer who calls configd_info() isn't as careful about
making sure the message is clearly related to the SMF repository as
you. We could probably do this later under a separate bug, though.
cmd/svc/configd/object.c
311-4: I suspect this would be clearer to people who don't know
backend.c very well as "since it's upgraded as soon as the backend
is writable." You don't have to change it, though.
David
