Quoth Tom Whitten on Thu, Dec 04, 2008 at 04:18:28PM -0700: > You and David seem to be differing on whether or not I should call > syslog(). I'm inclined to not call syslog() if door_ucred() returns > EINVAL, since that means that the door client went away. All other error > returns from door_ucred() should probably cause an abort by calling > bad_error(). They are: > > EAGAIN The location pointed to by info was NULL and allo- > cating memory sufficient to hold a ucred failed. > > EFAULT The address of the info argument is invalid. > > ENOMEM The location pointed to by info was NULL and allo- > cating memory sufficient to hold a ucred failed.
EFAULT: yes, the others: no. If we run out of memory, we should just fail the operation. We could try again after EAGAIN, but I doubt it's worth the effort. David
