David Bustos writes: > Quoth Tom Whitten on Thu, Dec 18, 2008 at 11:57:12AM -0700: > > I've incorporated the next round of changes suggested by David and Gary, > > and I reran the tests. There is a new full webrev showing the differences > > between my workspace and the onnv-clone at > > http://cr.opensolaris.org/~fourctom/audit_17_dec_2008/. In addition there > > is an incremental showing just the changes from my December 10 webrev. The > > incremental is at > > http://cr.opensolaris.org/~fourctom/incr_audit_17_dec_2008/. > > I would prefer to see the if statement at 5959 of rc_node.c removed, but > I suppose that whoever fixes rc_node_get_fmri_or_fragment() not to fail > should evaluate this code and eliminate it then, so I guess you don't > have to do it now. > > The rest looks ok. > > > David
When I fix 6787123 "rc_node_get_fmri_or_fragment should assert if the buffer is too small", I'll need to fix up all the places where rc_node_get_fmri_or_fragment() is called. 5959 will certainly be one of those. Thanks for all the time that you spent reviewing this code. tom
