Quoth Tom Whitten on Thu, Dec 11, 2008 at 12:07:29PM -0700: > I've incorporated the changes suggested by David and Gary. There is a new > full webrev showing the differences between my workspace and the onnv-clone > at http://cr.opensolaris.org/~fourctom/audit_10_dec_2008/. In addition > there is an incremental showing just the changes from my December 2 > webrev. The incremental is at > http://cr.opensolaris.org/~fourctom/incr_audit_10_dec_2008/.
cmd/svc/configd/client.c 1985: You should add a default case. I would probably add it to the EFAULT case, but since it's in libc, the EAGAIN case would be ok, too. cmd/svc/configd/rc_node.c 5507: Please use bad_error() here. 5955: If this assert()ion is valid, then isn't the following if statement superfluous? 6831: Shouldn't you also enter this conditional if ret == REP_PROTOCOL_FAIL_NO_RESOURCES, since that means map_granted_status() was unable to strdup() auth_string? David