Here's my review for the IPS packaging changes. I believe that completes my code review, please let me know if that statement is incorrect.
Jean *usr/src/pkg/redist/SUNWacc.mf*: OK *usr/src/pkg/redist/SUNWamt.mf:OK **usr/src/pkg/redist/SUNWatfs.mf:OK **usr/src/pkg/redist/SUNWbnu.mf:OK **usr/src/pkg/redist/SUNWbridge.mf:OK **usr/src/pkg/redist/SUNWbs.mf:OK **usr/src/pkg/redist/SUNWcfpl.mf:OK **usr/src/pkg/redist/SUNWckr.mf:OK **usr/src/pkg/redist/SUNWcns.mf:OK **usr/src/pkg/redist/SUNWcs.mf:OK **usr/src/pkg/redist/SUNWcsd.mf: OK **usr/src/pkg/redist/SUNWcvc.mf:OK **usr/src/pkg/redist/SUNWdcs.mf:**OK usr/src/pkg/redist/SUNWdhcs.mf:OK * *usr/src/pkg/redist/SUNWdscp.mf*:OK *usr/src/pkg/redist/SUNWdsd.mf:OK **usr/src/pkg/redist/SUNWefc.mf:OK **usr/src/pkg/redist/SUNWfcprt.mf:OK **usr/src/pkg/redist/SUNWfs.mf:OK **usr/src/pkg/redist/SUNWftp.mf:OK **usr/src/pkg/redist/SUNWgssc.mf:OK **usr/src/pkg/redist/SUNWhal.mf:OK **usr/src/pkg/redist/SUNWii.mf:OK **usr/src/pkg/redist/SUNWilb.mf:OK **usr/src/pkg/redist/SUNWipf.mf:OK **usr/src/pkg/redist/SUNWippl.mf:OK **usr/src/pkg/redist/SUNWiscsi.mf:OK **usr/src/pkg/redist/SUNWiscsit.mf:OK **usr/src/pkg/redist/SUNWiscsitgt.mf:OK **usr/src/pkg/redist/SUNWisns.mf:OK **usr/src/pkg/redist/SUNWkdc.mf:OK **usr/src/pkg/redist/SUNWkrb.mf:OK **usr/src/pkg/redist/SUNWldom.mf:OK **usr/src/pkg/redist/SUNWmd.mf:OK **usr/src/pkg/redist/SUNWmms.mf:OK **usr/src/pkg/redist/SUNWndmp.mf:OK **usr/src/pkg/redist/SUNWnfsc.mf:OK **usr/src/pkg/redist/SUNWnfss.mf:OK **usr/src/pkg/redist/SUNWnis.mf:OK **usr/src/pkg/redist/SUNWpicl.mf:OK **usr/src/pkg/redist/SUNWpkgcmds.mf:OK **usr/src/pkg/redist/SUNWpm.mf:OK **usr/src/pkg/redist/SUNWpool.mf:OK **usr/src/pkg/redist/SUNWppm.mf:OK **usr/src/pkg/redist/SUNWps.mf:OK *usr/src/pkg/redist/SUNWrcap.mf:OK *usr/src/pkg/redist/SUNWrcmds.mf:OK **usr/src/pkg/redist/SUNWrdc.mf:OK **usr/src/pkg/redist/SUNWrmvolmgr.mf:OK **usr/src/pkg/redist/SUNWroute.mf:OK **usr/src/pkg/redist/SUNWsacom.mf:OK **usr/src/pkg/redist/SUNWsckm.mf:OK **usr/src/pkg/redist/SUNWscm.mf:OK **usr/src/pkg/redist/SUNWsfdr.mf:OK **usr/src/pkg/redist/SUNWslp.mf:OK **usr/src/pkg/redist/SUNWsmbfs.mf:OK **usr/src/pkg/redist/SUNWsmbs.mf:OK **usr/src/pkg/redist/SUNWsmedia.mf:OK **usr/src/pkg/redist/SUNWsndm.mf:OK **usr/src/pkg/redist/SUNWspsv.mf:OK **usr/src/pkg/redist/SUNWsrpt.mf:OK **usr/src/pkg/redist/SUNWsshd.mf:OK **usr/src/pkg/redist/SUNWstmf.mf:OK **usr/src/pkg/redist/SUNWtnetd.mf:OK **usr/src/pkg/redist/SUNWts.mf: OK **usr/src/pkg/redist/SUNWtsg.mf:OK **usr/src/pkg/redist/SUNWusb.mf:OK **usr/src/pkg/redist/SUNWvrrp.mf:OK **usr/src/pkg/redist/SUNWvscan.mf:OK **usr/src/pkg/redist/SUNWwpa.mf:OK **usr/src/pkg/redist/SUNWxvmipa.mf:OK **usr/src/pkg/redist/SUNWyp.mf:OK **usr/src/pkg/redist/SUNWzone.mf:OK * * * * ** *On 02/5/10 03:21 PM, Tony Nguyen wrote: > We completed testing and fixed all found bugs. We'd appreciate > feedback by Feb 19th as that would allow us to turnaround comments and > still make the scheduled integration date. > > Webrev: > http://cr.opensolaris.org/~tonyn/EMI_webrev/ > > Design Doc: > http://hub.opensolaris.org/bin/download/Community+Group+smf/smf_design_docs/emidesign.html > > > > The number of modified files dramatically decreased since changes to > SVR4 packages are obsoleted. Susan and Jean, would you mind review the > IPS packaging changes and the Makefiles? > > Antonello and Liane, you guys still have the SMF changes :) > > Thanks in advance for your help, > -tn > > On 11/28/09 01:02 AM, Tony Nguyen wrote: >> Here's the long awaited webrev for Early Manifest Import. Relevant >> pointers are: >> >> Design Doc: >> http://caolila.sfbay:82/~tn143363/webrevs/EMI/emi_webrev_onnv_files/ >> >> ON IPS packaging webrev: >> http://caolila.sfbay:82/~tn143363/webrevs/EMI/emi_webrev_onnv_files/ >> >> ONNV webrev: >> http://caolila.sfbay:82/~tn143363/webrevs/EMI/emi_webrev_on_ips_files/ >> >> cscope repository: >> /net/kodiak.sfbay/builds/swilcox/EMI_ips_gate/usr/src >> >> Since the number of affected files is quite large, we decided to break >> the changes into two sets, packaging changes and SMF changes, with the >> following assignment to keep things manageable. >> >> Jean and Susan, would you mind review the ON IPS packaging files in the >> first webrev pointer as well as the SVR4 packaging files in the ONNV >> webrev? Of course, any additional comments on the SMF code would be >> welcome and appreciated. >> >> Antonello and Liane, would you mind review the SMF changes in the ONNV >> webrev link? > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/smf-discuss/attachments/20100209/8433f120/attachment.html>
