Wolfgang Grandegger wrote:
> Hi Sebastian,
>
> you just fix the lines I pointed to. There are more similar issues.
> For consitancy reasons, could you please do a global:
>
> s/canstate/can_state/g
> s/canmsg/canmsg/g
What's the difference here? :-)
>> +
>> +/* Representation of the CAN parameters for the M16C controller
>> + * in basic CAN mode (means no full CAN)
>> + */
>> +struct cpc_m16c_basic_params {
>> + u8 con0;
(..)
>> +/* Table of devices that work with this driver
>> + * NOTE: This driver supports only CPC-USB/ARM7 (LPC2119) yet.
>> + */
>> +static struct usb_device_id ems_usb_table[] = {
>> + /*{USB_DEVICE(USB_CPCUSB_VENDOR_ID, USB_CPCUSB_M16C_PRODUCT_ID)},*/
>
> Please remove.
>
I assume the M16C support will be added before upstream.
So to me this is a step in between and we do not need to remove all the stuff
that will get in before mainlining anyway.
>> +static void ems_usb_read_bulk_callback(struct urb *urb)
>> +{
>> + struct ems_usb *dev = urb->context;
>> + struct net_device *netdev;
>> +
>> + int retval;
>
> Remove empty line above, please.
> s/retval/err ?
>
s/retval/ret/ ?
I think this is ok.
Btw. This function is a *void* function, right?
This needs to be checked :-)
Regards,
Oliver
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
