Hi Sebastian, Fedora 11 provides Thunderbird 3.0b2, which is obviously buggy :-(. I now installed 2.0 and the problems with the DOS endings and wired space substitutions are gone. Sorry for the inconvenience it caused.
Sebastian Haas wrote: > This patch adds support for the CAN/USB interface CPC-USB/ARM7 from EMS > Dr. Thomas Wuensche. > > Signed-off-by: Sebastian Haas <[email protected]> > > Makefile | 1 > drivers/net/can/Kconfig | 7 > drivers/net/can/Makefile | 1 > drivers/net/can/ems_usb.c | 1140 > ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/can/dev.h | 2 > include/socketcan/can/dev.h | 2 > 6 files changed, 1151 insertions(+), 2 deletions(-) > > Index: include/linux/can/dev.h > =================================================================== > --- include/linux/can/dev.h (Revision 1048) > +++ include/linux/can/dev.h (Arbeitskopie) > @@ -32,7 +32,7 @@ > /* > * CAN common private data > */ > -#define CAN_ECHO_SKB_MAX 4 > +#define CAN_ECHO_SKB_MAX 10 > > struct can_priv { > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23) > Index: include/socketcan/can/dev.h > =================================================================== > --- include/socketcan/can/dev.h (Revision 1048) > +++ include/socketcan/can/dev.h (Arbeitskopie) > @@ -32,7 +32,7 @@ > /* > * CAN common private data > */ > -#define CAN_ECHO_SKB_MAX 4 > +#define CAN_ECHO_SKB_MAX 10 > > struct can_priv { > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23) For the moment I want to keep the old settings. We need to discuss how to handle this in a generic way. Either by increasing it to 8, let's say, or by providing a kernel config. Other opinions? I'm still not happy with a few coding issues, e.g.: > + struct ems_usb *dev = usb_get_intfdata(intf); > + struct ems_usb *dev = netdev_priv(netdev); > + struct ems_usb *priv = netdev_priv(dev); > +static int ems_usb_set_mode(struct net_device *dev, ... > +static int ems_usb_start_xmit(struct sk_buff *skb, struct net_device *netdev) The inconsistant use of dev, priv and netdev is confusing when you read the code. Also the error messages could still be improved. Anyhow, I'm going to apply the patch to the SVN trunk as is now. Feel free to improve the code quality when you have time. BTW: does hot plugging work properly? Thanks for your contribution. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
