Hi Kurt, Kurt Van Dijck wrote: > On Thu, Sep 10, 2009 at 01:29:34PM +0200, Wolfgang Grandegger wrote: >> Date: Thu, 10 Sep 2009 13:29:34 +0200 >> Subject: Re: [PATCH v3] ems_usb: CAN/USB driver for EMS CPC-USB/ARM7 CAN >> interfaces >> From: Wolfgang Grandegger <[email protected]> >> To: Sebastian Haas <[email protected]> >> Cc: SocketCAN Core Mailing List <[email protected]>, >> Oliver Hartkopp <[email protected]> >> >> Hi Sebastian, >> >> Fedora 11 provides Thunderbird 3.0b2, which is obviously buggy :-(. I >> now installed 2.0 and the problems with the DOS endings and wired space >> substitutions are gone. Sorry for the inconvenience it caused. >> >> Sebastian Haas wrote: >>> This patch adds support for the CAN/USB interface CPC-USB/ARM7 from EMS >>> Dr. Thomas Wuensche. >>> >>> Signed-off-by: Sebastian Haas <[email protected]> >>> >>> Makefile | 1 >>> drivers/net/can/Kconfig | 7 >>> drivers/net/can/Makefile | 1 >>> drivers/net/can/ems_usb.c | 1140 >>> ++++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/can/dev.h | 2 >>> include/socketcan/can/dev.h | 2 >>> 6 files changed, 1151 insertions(+), 2 deletions(-) >>> >>> Index: include/linux/can/dev.h >>> =================================================================== >>> --- include/linux/can/dev.h (Revision 1048) >>> +++ include/linux/can/dev.h (Arbeitskopie) >>> @@ -32,7 +32,7 @@ >>> /* >>> * CAN common private data >>> */ >>> -#define CAN_ECHO_SKB_MAX 4 >>> +#define CAN_ECHO_SKB_MAX 10 >>> >>> struct can_priv { >>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23) >>> Index: include/socketcan/can/dev.h >>> =================================================================== >>> --- include/socketcan/can/dev.h (Revision 1048) >>> +++ include/socketcan/can/dev.h (Arbeitskopie) >>> @@ -32,7 +32,7 @@ >>> /* >>> * CAN common private data >>> */ >>> -#define CAN_ECHO_SKB_MAX 4 >>> +#define CAN_ECHO_SKB_MAX 10 >>> >>> struct can_priv { >>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23) >> For the moment I want to keep the old settings. We need to discuss how >> to handle this in a generic way. Either by increasing it to 8, let's >> say, or by providing a kernel config. Other opinions? > with regard to CAN_ECHO_SKB_MAX, I had the same problem in the softing > driver. > would some interface like this: [...] > +struct net_device *alloc_candev(int sizeof_priv, int echo_skb_max);
This is a good solution if we want the driver to set the number of echo skb's. I would actually put the echo_skbs at the end of the netdev_priv(). Would it also be useful that the user decides via kernel configuration option? Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
