M F wrote: > Hi, > > it took longer than expected, but here is a patch to add support for > binary mode to slcan with error recovery! > Regards,
Some general comments. Please respect the Linux coding style. There are many issue: lines too long, // comments, comment style. Please use checkpatch.pl to spot coding style problems. Furthermore, don't mix coding style corrections and code beautifications with functional changes. Please provide separate patches. And this patch is line wrapped. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
