On Tue, Sep 15, 2009 at 05:56:06PM +0200, Maximilian Falkenstein wrote:
> Wolfgang Grandegger wrote:
> > Some general comments. Please respect the Linux coding style. There are
> > many issue: lines too long, // comments, comment style. Please use
> > checkpatch.pl to spot coding style problems.
> Ok, changed accordingly.
> > Furthermore, don't mix
> > coding style corrections and code beautifications with functional
> > changes. Please provide separate patches.
> Well, as I've changed the code to respect the Linux coding style, these
> changes should be gone now...
> > And this patch is line wrapped.
> Finally using another mail client for patches, should work now...
>
>
>
> Index: kernel/2.6/drivers/net/can/slcan.c
> ===================================================================
> --- kernel/2.6/drivers/net/can/slcan.c (Revision 1054)
> +++ kernel/2.6/drivers/net/can/slcan.c (Arbeitskopie)
> @@ -11,6 +11,7 @@
> * slip.c Authors : Laurence Culhane <[email protected]>
> * Fred N. van Kempen <[email protected]>
> * slcan.c Author : Oliver Hartkopp <[email protected]>
> + * Maximilian Falkenstein <[email protected]>
> *
> * Copyright (c) 2007-2009 Volkswagen Group Electronic Research
> *
> @@ -75,8 +76,10 @@
>
> #include <socketcan/can.h>
>
> +#if 0
> #include <socketcan/can/version.h> /* for RCSID. Removed by mkpatch script */
> RCSID("$Id$");
> +#endif
>
> static __initdata const char banner[] =
> KERN_INFO "slcan: serial line CAN interface driver\n";
> @@ -132,12 +135,25 @@
> module_param(maxdev, int, 0);
> MODULE_PARM_DESC(maxdev, "Maximum number of slcan interfaces");
>
> -/* maximum rx buffer len: extended CAN frame with timestamp */
> +/* MAX number of packets to put *
> + * into the device buffer, can *
> + * also be overridden */
This should look like this:
/*
* MAX number of packets to put into the device buffer, can
* also be overridden.
*/
You get this wrong in several spots.
Sam
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
