>-----Original Message-----
>From: Wolfgang Grandegger [mailto:[email protected]]
>Sent: Thursday, September 24, 2009 1:50 PM
>To: Gole, Anant
>Cc: [email protected]
>Subject: Re: [PATCH V3] net-next:can: add TI CAN (HECC) driver
>
>Hi Anant,
>
>I have a few more comments after a closer look...
>
>I suggest using BIT(n) for all (1 << n), not only the macro definitions.
> Also, often you use (1 << mbxno) in a sequence of expressions. I think
>using
>
> mbx_mask = BIT(mbxno);
>
>would be more efficient. A few more comments inline...
>
Complete agreed - in fact I have already done it in my code base - somehow
missed it in the v3 code I sent.
[snip]
>> +#define HECC_RX_BUFFER_MBOX 12 /* as per table above */
>
>Note sure if this value could be calculated as well.
I did not want to make it too complicated ... will leave it as is.
>[snip]
>> +static int ti_hecc_open(struct net_device *ndev)
>> +{
>> + struct ti_hecc_priv *priv = netdev_priv(ndev);
>> + int err;
>> +
>> + err = request_irq(ndev->irq, ti_hecc_interrupt, IRQF_DISABLED,
>
>Do you really need IRQF_DISABLED?
I don't - I will make it IRQF_SHARED
Regards,
Anant
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
