Hello, On 08/31/2010 10:35 AM, Wolfgang Grandegger wrote: > Hello, > > Thanks for your contribution. This is quick review of your driver. First > some general comments: > > - Do we really need a separate driver interface for the CCAN? Is > a platform driver with appropriate platform declarations in > "include/linx/can/platform/ccan.h" not sufficient? > > - If such a CCAN driver interface makes sense, the code should go into > a subdirectory named "ccan". > > - I would prefer "s/bosch_ccan/ccan/" for all names.
I had a close look to the manual. The offical name of the controller is "C_CAN". Therefore it would be nice to use that name as prefix as well, e.g. c_can_open(). Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
