Sorry for posting from Outlook-Webmail, but i have one remark for MSG_DONTROUTE before sending a patch: IMHO the bit should be inverted at the check in raw.c : + pflags = raw_flags(skb); + if (!(*pflags & RAWF_LOCAL)) + msg->msg_flags |= MSG_DONTROUTE; + if (*pflags & RAWF_SELF) + msg->msg_flags |= MSG_CONFIRM; +
As it would indicate that the message was *not* routed locally but came from the outside. Even if it's still not mega intuitive it IMO fits better to DONTROUTE :-) Or am i wrong here? Regards, Oliver (@UPV Valencia) ________________________________ Von: [email protected] im Auftrag von [email protected] Gesendet: Mi 2010-10-13 13:39 An: [email protected] Cc: [email protected] Betreff: RE: Self-reception Hi Kurt, > Can you confirm that this patch on socketCAN addresses > your problem? I know my post was a little messy :-). > If so, I'll continue and prepare a patch for netdev mailing list... Unfortunately I have no possibility to test your patch on the real system right now. What I see from source code is that your patch adds two message flags: MSG_DONTROUTE - the message is coming from other socket opened on the same CAN HW MSG_CONFIRM - the message is self-reception message If it is so, than I will be happy with it :) Regards, Vladislav _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
_______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
