Hi, I have had a review of the new version of this yang model. The model looks much better than the previous version and many thanks for the authors' effort. And from my perspective, I think this model could be further discussed in the following aspects. Please find my comments in the following.
1) The common module contains some definition groupings that are only applicable to the BR module (e.g. binding-entry and port-set), they should be excluded from the common module. 2) The BR module should also augments ietf-interfaces since they are also a tunnel endpoint and it is better to be consistent with the CE model. And in this way, we do not need to declare the redundant br-instance id or name anymore. 3) There are still some descriptions in the YANG code following the old version, these should be updated accordingly. 4) The usage of choice statement is not very clear, why do we need to use the 'case' and 'feature' statements together? It seems that we only need one of them. 5) It seems that the state parameters of CE module have duplicated node 'name' and 'type' since they have already been defined in the ietf-interfaces module. BR, Linhui
_______________________________________________ Softwires mailing list [email protected] https://www.ietf.org/mailman/listinfo/softwires
