Comment #18 on issue 44 by [email protected]: pitch recognition
http://code.google.com/p/solfege/issues/detail?id=44
Hi! I've been working very slowly on solfege-pitchrec branch. I came up
with a very
rough prototype.
To try the application you have to use the new exercise (mic_singinterval)
in the lessonfiles folder.
I deliberately copy-pasted code from the singinterval module, just to
discover where is the most part of duplicated code.
in the __init__ there's quite a lot of duplicated code. I was thinking
about refactoring in this way:
SuperClass.__init__
self.fill_practise_box()
self.fill_conifg_box()
self.setup_statistics()
Thus subclasses can just override the sensible methods without
needing to override the whole constructor as this leads to
boilerplate/duplication.
Concerning the other methods like on_start/stop_practise and new_question I
see that there's duplication. However I cannot say anything because I
haven't grasped
the logic and the test/custom-mode stuff; I just copied stuff around to
make it run.
Maybe you can say something about it.
I have also thought about how to handle the results. I've made it simple:
each time you make an
attempt, you have the result recorded, I think that I can came up with
a solution more consistent with the application.
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Solfege-devel mailing list
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe", or visit
https://lists.sourceforge.net/lists/listinfo/solfege-devel