svn commit: r727354 - /lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java

[shalin]

Author: shalin
Date: Wed Dec 17 04:06:47 2008
New Revision: 727354

URL: http://svn.apache.org/viewvc?rev=727354&view=rev
Log:
SOLR-913 -- Pattern and CommonsHttpClient made static

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java
URL: 
http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java?rev=727354&r1=727353&r2=727354&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java 
(original)
+++ lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java Wed Dec 
17 04:06:47 2008
@@ -95,7 +95,17 @@
    * Disable the timer task for polling
    */
   private AtomicBoolean pollDisabled = new AtomicBoolean(false);
-  private final HttpClient client = new HttpClient(new 
MultiThreadedHttpConnectionManager());
+
+  private static final HttpClient client;
+
+  static {
+    MultiThreadedHttpConnectionManager mgr = new 
MultiThreadedHttpConnectionManager();
+    // Keeping a very high number so that if you have a large number of cores
+    // no requests are kept waiting for an idle connection.
+    mgr.getParams().setDefaultMaxConnectionsPerHost(10000);
+    mgr.getParams().setMaxTotalConnections(10000);
+    client = new HttpClient(mgr);
+  }
 
   public SnapPuller(NamedList initArgs, ReplicationHandler handler, SolrCore 
sc) {
     solrCore = sc;
@@ -954,12 +964,11 @@
   }
 
   static Integer readInterval(String interval) {
-    Pattern pattern = Pattern.compile(INTERVAL_PATTERN);
     if (interval == null)
       return null;
     int result = 0;
     if (interval != null) {
-      Matcher m = pattern.matcher(interval.trim());
+      Matcher m = INTERVAL_PATTERN.matcher(interval.trim());
       if (m.find()) {
         String hr = m.group(1);
         String min = m.group(2);
@@ -988,7 +997,6 @@
 
   public void destroy() {
     if (executorService != null) executorService.shutdown();
-    client.getHttpConnectionManager().closeIdleConnections(0);
   }
 
   String getMasterUrl() {
@@ -1011,5 +1019,5 @@
 
   public static final String INTERVAL_ERR_MSG = "The " + POLL_INTERVAL + " 
must be in this format 'HH:mm:ss'";
 
-  private static final String INTERVAL_PATTERN = "(\\d*?):(\\d*?):(\\d*)";
+  private static final Pattern INTERVAL_PATTERN = 
Pattern.compile("(\\d*?):(\\d*?):(\\d*)");
 }