[ 
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606424#action_12606424
 ] 

Yonik Seeley commented on SOLR-502:
-----------------------------------

Thanks Sean, that definitely cuts down the patch size, and it seems nicer not 
to be touching DocSet and ResponseWriters, etc.  What's your take?

Another thing to consider is perhaps a SolrIndexSearcher.search() method that 
uses a command pattern to avoid having to always change the signatures when we 
want to pass something new in or out?  It might be more natural than passing 
down an un-typed NamedList

{code}
QueryCommand {
  Query q
  Sort s
  List<Query> filters
  DocSet filter
  int flags
  int timeout
  ...
}

QueryResult {
  DocList list
  DocSet set
  boolean timedOut
  ...
}
{code}

> Add search time out support
> ---------------------------
>
>                 Key: SOLR-502
>                 URL: https://issues.apache.org/jira/browse/SOLR-502
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Sean Timm
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, 
> SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, 
> solrTimeout.patch, solrTimeout.patch, solrTimeout.patch
>
>
> Uses LUCENE-997 to add time out support to Solr.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to