[ 
https://issues.apache.org/jira/browse/SOLR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606473#action_12606473
 ] 

Sean Timm commented on SOLR-502:
--------------------------------

bq. that definitely cuts down the patch size [...] What's your take?

Before I made the change, I was against it as it seems more logical to have the 
partialResults associated with the results list, where the total count, etc. 
are.  But this greatly simplifies the patch.  I could go either way.

bq.  Another thing to consider is perhaps a SolrIndexSearcher.search() method 
that uses a command pattern

I think I agree. :-)  How is this different than my suggestion of passing the 
ResponseBuilder into the searcher?  It seems that it would be useful to take it 
even a step further and pass the ResonseBuilder object around everywhere 
including the response handlers and writers.

> Add search time out support
> ---------------------------
>
>                 Key: SOLR-502
>                 URL: https://issues.apache.org/jira/browse/SOLR-502
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Sean Timm
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-502.patch, SOLR-502.patch, SOLR-502.patch, 
> SOLR-502.patch, SOLR-502.patch, solrTimeout.patch, solrTimeout.patch, 
> solrTimeout.patch, solrTimeout.patch, solrTimeout.patch
>
>
> Uses LUCENE-997 to add time out support to Solr.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to