[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro updated SOLR-647:
-------------------------------
Attachment: solr-647.patch
bq. Yes, if cores obtained through other methods need to be open for some
reason, then open() would need to be called.
bq. I'm not sure if we have any cases like that.
No, we don't have any cases today. It could have been useful to someone
implementing another filter or servlet.
Since the same effect can be obtained with:
{code}
CoreDescriptor dcore;
CoreContainer container;
...
SolrCore opened = container.getCore(dcore.getName());
{code}
open() can just be incrementAndGet(). (finally!:-))
bq.LOG.severe("XYZ happened. Please report this problem on [EMAIL PROTECTED]")
Seems to be the consensus; updated.
bq.The CoreContainer#create(CoreDescriptor dcore) must close the old core after
creating the new one
Correct, fixed.
> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
> Key: SOLR-647
> URL: https://issues.apache.org/jira/browse/SOLR-647
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Grant Ingersoll
> Fix For: 1.3
>
> Attachments: refcount_example.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
> solr-647.patch, solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause
> Exceptions for in-flight requests. The _close()_ method should just do a
> decrement on refcount and the actual close must happen when the last request
> being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
