[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625028#action_12625028
]
henrib edited comment on SOLR-716 at 8/23/08 12:19 AM:
--------------------------------------------------------------
Setting aside the potential debate of using regexp to solve a DOM related
problem... :-)
bq.SolrResourceLoader keeps a reference to the CoreDescriptor
It would seem preferable & possible to only store the properties (versus the
CoreDescriptor) in the SolrResourceLoader; this is the only piece needed for
evaluation.
IMHO, the CoreDescriptor giving potential access to everything (through the
CoreContainer), it should not be shared/stored outside of the SolrCore without
careful impact consideration.
bq. users cannot specify a variable inside solr.xml
You could do a second evaluation pass to expand the property values (if they
are property expressions) created for the CoreContainer and for each
CoreDescriptor.
If you were though, you'd need to keep the property expression map & the
property value map separated.
was (Author: henrib):
bq.SolrResourceLoader keeps a reference to the CoreDescriptor
It would seem preferable & possible to only store the properties (versus the
CoreDescriptor) in the SolrResourceLoader; this is the only piece needed for
evaluation.
IMHO, the CoreDescriptor giving potential access to everything (through the
CoreContainer), it should not be shared/stored outside of the SolrCore without
careful impact consideration.
bq. users cannot specify a variable inside solr.xml
You could do a second evaluation pass to expand the property values (if they
are property expressions) created for the CoreContainer and for each
CoreDescriptor.
If you were though, you'd need to keep the property expression map & the
property value map separated.
> Support properties in configuration files
> -----------------------------------------
>
> Key: SOLR-716
> URL: https://issues.apache.org/jira/browse/SOLR-716
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: SOLR-716.patch
>
>
> Initially suggested by Hoss at
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
> and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
> <property name="var" value="value" />
> <cores adminPath="/admin/cores">
> <core name="core0" instanceDir="core0">
> <property name="var" value="value" />
> </core>
> <core name="core1" instanceDir="core1" />
> </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order --
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is
> (without evaluation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
