[ 
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625040#action_12625040
 ] 

henrib edited comment on SOLR-716 at 8/23/08 2:45 AM:
-------------------------------------------------------------

property expressions can be used in solr.xml & are preserved during solr.xml 
persistence (solr-716.patch).

bq. If you were though, you'd need to keep the property expression map & the 
property value map separated
CoreDescriptor members can be property expressions - thus a map of expressions 
in both CoreDescriptor & CoreContainer to keep them around so we can reevaluate 
& persist them.
.
substituteProperties is made explicit so we can choose when to run it (instead 
of a ctor modification) and the substituteProperties() method would have been 
necessary anyway in that case.

      was (Author: henrib):
    property expressions in solr.xml & preserved during solr.xml persistence.
CoreDescriptor members can be property expressions - thus a map of expressions 
in both CoreDescriptor & CoreContainer.
substituteProperties is made explicit so we can choose when to run it (instead 
of a ctor modification)
  
> Support properties in configuration files
> -----------------------------------------
>
>                 Key: SOLR-716
>                 URL: https://issues.apache.org/jira/browse/SOLR-716
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.3
>
>         Attachments: solr-716.patch, SOLR-716.patch, SOLR-716.patch
>
>
> Initially suggested by Hoss at 
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
>  and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in 
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
>   <property name="var" value="value" />
>   <cores adminPath="/admin/cores">
>     <core name="core0" instanceDir="core0">
>       <property name="var" value="value" />
>     </core>
>     <core name="core1" instanceDir="core1" />
>   </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order -- 
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is 
> (without evaluation).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to