I guess so. static Objects live in the permgen keep as few as possible On Sun, Dec 14, 2008 at 11:21 PM, Shalin Shekhar Mangar (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656422#action_12656422 > ] > > Shalin Shekhar Mangar commented on SOLR-913: > -------------------------------------------- > > bq. this object is used only in the startup a couple of times It is better to > use it and throw away rather than holding on to the reference forever > > I just committed this, too trigger happy you see :) > > But I see your point, this method is used on startup only. Is it worth > reverting this change? > >> org/apache/solr/handler/SnapPuller.java - Expensive Pattern object made >> static >> -------------------------------------------------------------------------------- >> >> Key: SOLR-913 >> URL: https://issues.apache.org/jira/browse/SOLR-913 >> Project: Solr >> Issue Type: Improvement >> Components: clients - java >> Environment: Tomcat 6, JRE 6 >> Reporter: Kay Kay >> Fix For: 1.4 >> >> Attachments: SOLR-913.patch >> >> Original Estimate: 2h >> Remaining Estimate: 2h >> >> In the class - org.apache.solr.handler.SnapPuller - there seems to be an >> expensive Pattern object created locally in the method >> static Integer readInterval(String interval) ; >> Pattern instances are better created as static objects and reused. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
-- --Noble Paul
