[
https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656429#action_12656429
]
Shalin Shekhar Mangar commented on SOLR-913:
--------------------------------------------
bq. The bigger problem that we are trying to address on our end is a fast
SolrCore shutdown and restart and this is part of the bigger picture.
This does not cause longer shutdowns. If it is used only once in the lifetime
of a core, why would we need to keep it around all the time?
bq. If necessary - they could be wrapped around as a resource handler that can
set the static reference to null after the last use so that the static
reference does not take up the space.
As Noble pointed out, it is not used more than once. Keeping it static and then
nulling the reference after the only use, serves no purpose.
bq. Allowing this to persist because we have 2 calls might affect the
scalability as some other piece of code , inadvertently uses the same.
I do not understand this point at all.
> org/apache/solr/handler/SnapPuller.java - Expensive Pattern object made
> static
> --------------------------------------------------------------------------------
>
> Key: SOLR-913
> URL: https://issues.apache.org/jira/browse/SOLR-913
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Environment: Tomcat 6, JRE 6
> Reporter: Kay Kay
> Fix For: 1.4
>
> Attachments: SOLR-913.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In the class - org.apache.solr.handler.SnapPuller - there seems to be an
> expensive Pattern object created locally in the method
> static Integer readInterval(String interval) ;
> Pattern instances are better created as static objects and reused.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
