[ https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656711#action_12656711 ]
Kay Kay commented on SOLR-913: ------------------------------ > Is it true that you have a large no:of cores and you start/stop them very > frequently and the start/stop performance is a concern for you? Unfortunately yes. Hence my focus has been primarily on profiling the code path to start the solr system and hence to stress this. I agree with your concern about having static objects being live (after their intended use ) affecting memory but may be that could be grouped under ResourceMap but recreating the Pattern object , internally with all the NFA graph compilation would be better to be optimized as against the memory constraint. > org/apache/solr/handler/SnapPuller.java - Expensive Pattern object made > static > -------------------------------------------------------------------------------- > > Key: SOLR-913 > URL: https://issues.apache.org/jira/browse/SOLR-913 > Project: Solr > Issue Type: Improvement > Components: replication (java) > Environment: Tomcat 6, JRE 6 > Reporter: Kay Kay > Fix For: 1.4 > > Attachments: SOLR-913.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > In the class - org.apache.solr.handler.SnapPuller - there seems to be an > expensive Pattern object created locally in the method > static Integer readInterval(String interval) ; > Pattern instances are better created as static objects and reused. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.