[ 
https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677799#action_12677799
 ] 

Uwe Schindler commented on SOLR-940:
------------------------------------

Looks cool, great!
I have no Solr installed here to test in large scale, but from what I see, It 
seems sophisticated. I have only seen these points:
 - Missing support for half-open ranges with "\*" (just add the test for "\*" 
and pass null to TrieRangeFilter)
 - The example with a different configured precisionStep should use a 
precisionStep < 8 [16 is a possible value, but useless,because of number of 
terms. The possible number of terms increses dramatically with higher precision 
steps (factor 2^precisionStep). Javadocs should note, that 32/64 should be used 
for no additional trie fields]
 - Date support should be trivial, too.
 - Does it work with the tokenizer for standard term queries? e.g. somebody 
asks for all documents containing the long value x, but not using a TrieRange 
for that (this works, but can solr handle this?), is the value correctly 
tokenized? The problem here maybe that during parsing the query, the analyzer 
is used and generates a "OR" BolleanQuery of all terms incl lower precisions. 
Or is for the query another tokenizer used (but then this tokenizer should just 
generate one term using XxxxToPrefixCoded (without shift).

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>             Fix For: 1.4
>
>         Attachments: SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to