[ 
https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-940:
---------------------------------------

    Attachment: SOLR-940-rangequery.patch

>From Hoss on solr-dev about the last patch:
{quote}
I don't think treating "*" as special is something FieldType (or
TrieField) should do -- that's specific to the syntax of the QueryParser.
The FieldType classes should treat the string as a string. (otherwise if i
write a new QueryParser where * isn't a special character and use some
syntax like "phoneNumber < *69" i'm screwed.
"*69" as the

I also think having a single "inclusive" boolean is a bad idea.

I would javadoc that the lower/upper bounds can be null, and have
SolrQueryParser pass null when it sees "*" in the syntax.  we should also
be explicit in the javadocs about what combinations of inclusion booleans
and null values are allowed so that subclasses know what to expect
{quote}

In this patch:
# FieldType no longer treats '*' specially
# SolrQueryParser passes null for '*'
# Single inclusive parameter replaced by two parameters -- minInclusive and 
maxInclusive
# Javadoc updated to mention that nulls are allowed for part1 and part2, 
SolrQueryParser passes null for '*' character and same (true) values for 
minInclusive and maxInclusive. However other QueryParsers may have different 
semantics.
# Corresponding changes to TrieField

I'll commit shortly.

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-940-rangequery.patch, SOLR-940-rangequery.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, 
> SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to