I was just tinkering with creating a simple update processor (coming soon in a new JIRA issue) and used SignatureUpdateProcessorFactory as a starting example. A couple of things I noticed:

- several methods are overridden, but are basically just deferring to what the base class already does (processDelete, processCommit...). Perhaps these should simply be removed?

- the loadClass method does a Class.forName - but this will only work when the class is in solr.war, not if it is coming from the Solr home lib/ subdirectory. Shouldn't SolrResourceLoader be used instead?

        Erik

Reply via email to