On Tue, Jul 14, 2009 at 4:23 PM, Erik Hatcher <[email protected]>wrote:
> I was just tinkering with creating a simple update processor (coming soon > in a new JIRA issue) and used SignatureUpdateProcessorFactory as a starting > example. A couple of things I noticed: > > - several methods are overridden, but are basically just deferring to what > the base class already does (processDelete, processCommit...). Perhaps > these should simply be removed? Sure! No need for them. Good Point - probably started with them all trying to understand what I wanted to do and then just ended up leaving them, not remembering the base class is abstract with default impls. Good spot there. > > > - the loadClass method does a Class.forName - but this will only work when > the class is in solr.war, not if it is coming from the Solr home lib/ > subdirectory. Shouldn't SolrResourceLoader be used instead? > > Erik > > Absolutely. Very nice catch! This was one of my first patch's submitted to Solr - I didn't even realize I should use SolrResourceLoader at the time. I will fix it up! -- -- - Mark http://www.lucidimagination.com
