[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

[Yonik Seeley (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745468#action_12745468
 ] 

Yonik Seeley commented on SOLR-1275:
------------------------------------

Hmmm, it's harder to see in diff format... the test just boils down to this:

{code}
  public void testExpungeDeletes() throws Exception {
    assertU(adoc("id","1"));
    assertU(adoc("id","2"));
    assertU(commit());

    assertU(adoc("id","3"));
    assertU(adoc("id","2"));
    assertU(adoc("id","4"));
    assertU(commit());

    SolrQueryRequest sr = req("q","foo");
    SolrIndexReader r = sr.getSearcher().getReader();
    assertTrue(r.maxDoc() > r.numDocs());   // should have deletions
    assertTrue(r.getLeafReaders().length > 1);  // more than 1 segment
    sr.close();

    assertU(commit("expungeDeletes","true"));

    sr = req("q","foo");
    r = sr.getSearcher().getReader();
    assertEquals(r.maxDoc(), r.numDocs());  // no deletions
    assertTrue(r.getLeafReaders().length > 1);  // still more than 1 segment
    sr.close();
  }
{code}

> Add expungeDeletes to DirectUpdateHandler2
> ------------------------------------------
>
>                 Key: SOLR-1275
>                 URL: https://issues.apache.org/jira/browse/SOLR-1275
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.3
>            Reporter: Jason Rutherglen
>            Assignee: Noble Paul
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: SOLR-1275.patch, SOLR-1275.patch, SOLR-1275.patch, 
> SOLR-1275.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> expungeDeletes is a useful method somewhat like optimize is offered by 
> IndexWriter that can be implemented in DirectUpdateHandler2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.