[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747446#action_12747446 ]
Yonik Seeley commented on SOLR-1275: ------------------------------------ bq. if we don't test to insure the segments with deletes are in fact gone, we're unfortunately not testing the functionality of the method. Do we need to? We should be testing that the method is called and look for evidence that it has done it's work. All of the corner cases of testing if it did it's work correctly would seem to belong in Lucene unit tests? > Add expungeDeletes to DirectUpdateHandler2 > ------------------------------------------ > > Key: SOLR-1275 > URL: https://issues.apache.org/jira/browse/SOLR-1275 > Project: Solr > Issue Type: Improvement > Components: update > Affects Versions: 1.3 > Reporter: Jason Rutherglen > Assignee: Noble Paul > Priority: Trivial > Fix For: 1.4 > > Attachments: SOLR-1275.patch, SOLR-1275.patch, SOLR-1275.patch, > SOLR-1275.patch, SOLR-1275.patch, SOLR-1275.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > expungeDeletes is a useful method somewhat like optimize is offered by > IndexWriter that can be implemented in DirectUpdateHandler2. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.