[ 
https://issues.apache.org/jira/browse/SOLR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747754#action_12747754
 ] 

Robert Muir commented on SOLR-1362:
-----------------------------------

actually one last thing Yonik, at the beginning of the processing loop (now i 
am just nitpicking)

{code}
     //skip protected tokens
      if (protWords != null && protWords.contains(termBuffer, 0, len)) {
        return t;
      }

      int posInc = t.getPositionIncrement();
      origPosIncrement += posInc;
      ...
{code}

I should have written testcase, but don't you think if you have a LUCENE / SOLR 
where "/" has a huge gap, and SOLR is in 'protWords' that this might result in 
strange behavior?


> WordDelimiterFilter position increment bug
> ------------------------------------------
>
>                 Key: SOLR-1362
>                 URL: https://issues.apache.org/jira/browse/SOLR-1362
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: SOLR-1362.patch, SOLR-1362.patch, SOLR-1362.patch, 
> SOLR-1362_tests.txt
>
>
> WordDelimiterFilter sometimes assigns high position increment values, which 
> inhibits phrase matches.
> If this is a feature and not a bug please change the issue type, and I will 
> change the patch to propose this as an option...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to