[ 
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fergus McMenemie updated SOLR-1437:
-----------------------------------

    Comment: was deleted

(was: A patch of XPathRecordReader.java adding a few cosmetic changes to 
comments plus.....

A rewritten core of the parse() method. IMHO it is simpler to understand with 
the inner while and special paser.next state variable removed and it is 
probably faster as well.

Rearranged method getOrAddChild renaming it to getOrAddNode in preparation for 
adding support for // construct. This method is called from build().

While in build(), renamed local variable "name" to "xpseg" to better reflect 
that it holds a segment from an Xpath. And to remove warnings about local 
variables masking class variables.

"ant clean test" runs OK with these changes!)

> DIH: Enhance XPathRecordReader to deal with //tagname and other improvments.
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-1437
>                 URL: https://issues.apache.org/jira/browse/SOLR-1437
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Fergus McMenemie
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-1437.patch, SOLR-1437.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> As per 
> http://www.nabble.com/Re%3A-Extract-info-from-parent-node-during-data-import-%28redirect%3A%29-td25471162.html
>  it would be nice to be able to use expressions such as //tagname when 
> parsing XML documents.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to