[ 
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760602#action_12760602
 ] 

Fergus McMenemie commented on SOLR-1437:
----------------------------------------

Making good progress! The //expression and its testcase is done and appear to 
work well. I would have submitted a patch already except that having only 
altered "XPathRecordReader.java" I am now trying to get "ant clean test" to 
stop failing in org.apache.solr.handler.dataimport.TestErrorHandling.

Also while I do not yet have a total grasp of the code I think it is possible 
to have XPathRecordReader.java only return fields which are children of the 
forEach expression when a record is emitted. I consider this desirable and 
would like to press ahead with this extra change; are there other views?

Having established that "Set<String> valuesAddedinThisFrame" and 
"Stack<Set<String>> stack", in Node are only used for clearing up after a 
record has been emitted. I am now pondering the purpose of the HashSet 
childrenFound and putNulls. Any suggestions?

Lastly what are the chances of this making the 1.4 release?

> DIH: Enhance XPathRecordReader to deal with //tagname and other improvments.
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-1437
>                 URL: https://issues.apache.org/jira/browse/SOLR-1437
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Fergus McMenemie
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-1437.patch, SOLR-1437.patch, SOLR-1437.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> As per 
> http://www.nabble.com/Re%3A-Extract-info-from-parent-node-during-data-import-%28redirect%3A%29-td25471162.html
>  it would be nice to be able to use expressions such as //tagname when 
> parsing XML documents.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to