[
https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789911#action_12789911
]
Noble Paul commented on SOLR-1644:
----------------------------------
bq.While we should make it easy for custom components to store their own flags
+ state, etc, we should be careful about hiding the state of well known
components
By keeping the key public we ensure that other components can see/change it.
bq.it eliminates a hash lookup for each component each time through the loop
We do 100s of hash lookups in each request. This one change can keep the
ResponseBuilder from being a kitchen sink and the design cleaner .
bq.Is the plan to have a KEY per component instance? If so, how would it be
possible to refer to the key from other components?
you are right. We should make it public static. I hope that there aren't
multiple instances of the same component registered in the same handler
> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
> Key: SOLR-1644
> URL: https://issues.apache.org/jira/browse/SOLR-1644
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.5
>
> Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and
> helper objects in ResponseBuilder. Having to modify the ResponseBuilder for
> such things is a very kludgy solution.
> Let us provide a clean way for components to keep arbitrary objects for the
> duration of a (distributed) search request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
