[
https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789986#action_12789986
]
Noble Paul commented on SOLR-1644:
----------------------------------
bq.But perhaps we should have gone with the same strategy as the
UpdateProcessorChain
yes, it is. because there are more than one method call per component per
request. Should we still try to do it?
bq.Changing from a method or member to a hash lookup doesn't reduce a
dependency when it's needed.
not true. The fact is that ResponseBuilder stops depending on other components
. It is ok for components to depend on ResponseBuilder.
bq. I believe a Store interface can help here which provide access to data by a
key
Looks better.
> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
> Key: SOLR-1644
> URL: https://issues.apache.org/jira/browse/SOLR-1644
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.5
>
> Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and
> helper objects in ResponseBuilder. Having to modify the ResponseBuilder for
> such things is a very kludgy solution.
> Let us provide a clean way for components to keep arbitrary objects for the
> duration of a (distributed) search request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
