[ 
https://issues.apache.org/jira/browse/SOLR-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790865#action_12790865
 ] 

Robert Muir commented on SOLR-1657:
-----------------------------------

bq. + test classes that use old stuff for testing 

in fact I am working on the tests first. In my opinion what we should do is 
take the functionality of lucene's BaseTokenStreamTestCase and add it to 
BaseTokenTestCase.
Perhaps this old stuff can be implemented on top of assertTokenStreamContents, 
assertAnalyzesTo, etc, or we can change the tests.

Either way, my reasoning is that this logic is very careful about ensuring that 
tokenstreams behave properly, it inserts garbage data to make sure that 
attributes are cleared correctly, etc, etc.


> convert the rest of solr to use the new tokenstream API
> -------------------------------------------------------
>
>                 Key: SOLR-1657
>                 URL: https://issues.apache.org/jira/browse/SOLR-1657
>             Project: Solr
>          Issue Type: Task
>            Reporter: Robert Muir
>
> org.apache.solr.analysis:
> BufferedTokenStream
>  -> CommonGramsFilter
>  -> CommonGramsQueryFilter
>  -> RemoveDuplicatesTokenFilter
> CapitalizationFilterFactory
> HyphenatedWordsFilter
> LengthFilter (deprecated, remove)
> PatternTokenizerFactory (remove deprecated methods)
> SynonymFilter
> SynonymFilterFactory
> WordDelimiterFilter
> org.apache.solr.handler:
> AnalysisRequestHandler
> AnalysisRequestHandlerBase
> org.apache.solr.handler.component:
> QueryElevationComponent
> SpellCheckComponent
> org.apache.solr.highlight:
> DefaultSolrHighlighter
> org.apache.solr.search:
> FieldQParserPlugin
> org.apache.solr.spelling:
> SpellingQueryConverter

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to