[ 
https://issues.apache.org/jira/browse/SOLR-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798199#action_12798199
 ] 

Robert Muir commented on SOLR-1657:
-----------------------------------

Yonik, I agree, this is almost what the current patch does (take a look if you 
want, SOLR-1710).

There is one difference i must change, the 'when WDF is just removing 
punctuation' case. Current patch does not preserve attributes for this case 
(you must use preserveOriginal=true)

But the odd thing about this will be, when 'WDF is just removing punctuation' 
&& preserveOriginal == true, obviously the attributes will only apply to the 
original... does this make sense? 

I will make the change to the SOLR-1710 patch.


> convert the rest of solr to use the new tokenstream API
> -------------------------------------------------------
>
>                 Key: SOLR-1657
>                 URL: https://issues.apache.org/jira/browse/SOLR-1657
>             Project: Solr
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: SOLR-1657.patch, SOLR-1657.patch
>
>
> org.apache.solr.analysis:
> BufferedTokenStream
>  -> -CommonGramsFilter-
>  -> -CommonGramsQueryFilter-
>  -> -RemoveDuplicatesTokenFilter-
> -CapitalizationFilterFactory-
> -HyphenatedWordsFilter-
> -LengthFilter (deprecated, remove)-
> SynonymFilter
> SynonymFilterFactory
> WordDelimiterFilter
> org.apache.solr.handler:
> AnalysisRequestHandler
> AnalysisRequestHandlerBase
> org.apache.solr.handler.component:
> QueryElevationComponent
> SpellCheckComponent
> org.apache.solr.highlight:
> DefaultSolrHighlighter
> org.apache.solr.search:
> FieldQParserPlugin
> org.apache.solr.spelling:
> SpellingQueryConverter

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to