[ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-1674: ------------------------------ Attachment: SOLR-1674.patch here is an updated patch. I think I managed to resolve some problems with synonymfilter, especially the recursion tests (I believe they were simply typos and there isnt a bug), and the position increments (this was a problem in the tests) so in my opinion, the only problem left is SOLR-1670, the repeat problem. > improve analysis tests, cut over to new API > ------------------------------------------- > > Key: SOLR-1674 > URL: https://issues.apache.org/jira/browse/SOLR-1674 > Project: Solr > Issue Type: Test > Components: Schema and Analysis > Reporter: Robert Muir > Attachments: SOLR-1674.patch, SOLR-1674.patch > > > This patch > * converts all analysis tests to use the new tokenstream api > * converts most tests to use the more stringent assertion mechanisms from > lucene > * adds new tests to improve coverage > Most bugs found by more stringent testing have been fixed, with the exception > of SynonymFilter. > The problems with this filter are more serious, the previous tests were > essentially a no-op. > The new tests for SynonymFilter test the current behavior, but have FIXMEs > with what I think the old test wanted to expect in the comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.