[ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793005#action_12793005 ]
Mark Miller edited comment on SOLR-1674 at 12/20/09 5:13 PM: ------------------------------------------------------------- Thats BS - they are fixable in the patch ;) I hate those damn $id tags - every time ... I'll fix them. was (Author: markrmil...@gmail.com): Thats BS - they are fixable in the patch ;) I had those damn $id tags - every time ... I'll fix them. > improve analysis tests, cut over to new API > ------------------------------------------- > > Key: SOLR-1674 > URL: https://issues.apache.org/jira/browse/SOLR-1674 > Project: Solr > Issue Type: Test > Components: Schema and Analysis > Reporter: Robert Muir > Attachments: SOLR-1674.patch, SOLR-1674.patch > > > This patch > * converts all analysis tests to use the new tokenstream api > * converts most tests to use the more stringent assertion mechanisms from > lucene > * adds new tests to improve coverage > Most bugs found by more stringent testing have been fixed, with the exception > of SynonymFilter. > The problems with this filter are more serious, the previous tests were > essentially a no-op. > The new tests for SynonymFilter test the current behavior, but have FIXMEs > with what I think the old test wanted to expect in the comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.