[ 
https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796123#action_12796123
 ] 

Shalin Shekhar Mangar commented on SOLR-1212:
---------------------------------------------

bq. Keeping this out of the codebase would result in the patch being out of 
sync with the tree. If there were no licensing restrictions - what is the harm 
in having this in the tree.

You wrote this because you needed it at work and I appreciate that you thought 
about contributing it to Solr. But from Solr's perspective it is not needed and 
therefore I don't see why we should ship it at all. It is a class that is not 
used by Solr but would need to be maintained by us if we ship it.

> TestNG Test Case 
> -----------------
>
>                 Key: SOLR-1212
>                 URL: https://issues.apache.org/jira/browse/SOLR-1212
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - java
>    Affects Versions: 1.4
>         Environment: Java 6
>            Reporter: Kay Kay
>             Fix For: 1.5
>
>         Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether . 
> New Class created: AbstractSolrNGTest 
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache 
> License 2.0 ) 
> TestNG 5.9-jdk15 added to lib. 
> Justification:  In some workplaces - people are moving towards TestNG and 
> take out JUnit altogether from the classpath. Hence useful in those cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to