[
https://issues.apache.org/jira/browse/SOLR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796953#action_12796953
]
Hoss Man commented on SOLR-1212:
--------------------------------
I'm on the fence ...
i agree it's (probably) useful to TestNG users and i would like to do as much
as possible to make it easy for people to use the TestHarness (regardless of
how they write tests) but the idea of including it in the release does "smell
fishy" if we're not actually using it anywhere in Solr -- it may not seem like
much overhead to maintain it, but if it never gets used internally then it's
not really clear if/when there are problems with it (even Test code needs to be
tested to be sure that it's not broken).
If it's not included in the Solr repository, then it may fall out of sync with
Solr -- but that's true of any plugin someone writes and hosts on sourceforge,
or github, or googlecode -- we can advertise that it works with Solr 1.4, and
if something changes in Solr 1.5, or Solr 1.6 or Solr 9.7 that breaks it then
interested parties are free to update it with new version that does work.
...If i knew more about TestNG i might be able to form a stronger opinion like
"this is awesome, it's super useful, we should include it" or "this doesn't
really provide any value add to users" but I just don't know enough either way.
> TestNG Test Case
> -----------------
>
> Key: SOLR-1212
> URL: https://issues.apache.org/jira/browse/SOLR-1212
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.4
> Environment: Java 6
> Reporter: Kay Kay
> Fix For: 1.5
>
> Attachments: SOLR-1212.patch, testng-5.9-jdk15.jar
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> TestNG equivalent of AbstractSolrTestCase , without using JUnit altogether .
> New Class created: AbstractSolrNGTest
> LICENSE.txt , NOTICE.txt modified as appropriate. ( TestNG under Apache
> License 2.0 )
> TestNG 5.9-jdk15 added to lib.
> Justification: In some workplaces - people are moving towards TestNG and
> take out JUnit altogether from the classpath. Hence useful in those cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
