[
https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847177#action_12847177
]
Hoss Man commented on SOLR-1817:
--------------------------------
Tangential Comment...
If we *do* decide that it's worth keeping abortOnConfigurationError, then my
earlier suggestion of how it should work was overly complicated...
{quote}
a) SolrCore should itself maintain a list of "Severe Initialization Exceptions"
that it was able to "get passed" when initializing itself. specificly: when a
plugin could not be initialized, and it therefore is ignoring that plugin
declaration.
b) SolrCore should expose an easy way of asking it for it's list of
initialization exceptions
c) SolrCore should pay attention to wether it's solrconfig.xml file indicats if
the core should be usable if there were severe initialization exceptions.
d) SolrCore should refuse to "execute" any requests if (a) contains Exceptions
and (c) is true
{quote}
There's really no reason for SolrCore to maintain/expose a special list of
Exceptions and fail to execute if solrconfig says it should.
Instead: SolrCore can maintain a list of Exception during is initialization and
then if solrconfig.xml says abortOnConfigurationError=true, the the last line
of the SolrCore constructor can check check if the list is empty, and throw a
nice fat SOlrException wrapping that List if it's not, which CoreContainer can
keep track of (just like any solrconfig.xml or schema.xml parse exceptions that
it might encounter before that.)
(this would change the behavior of "new SolrCore" when
abortOnConfigurationError=true for embedded users constructing it themselves --
but frankly i think it changes it in a good way)
> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
> Key: SOLR-1817
> URL: https://issues.apache.org/jira/browse/SOLR-1817
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with
> multi-core (not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this
> changes solrconfigs abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are
> shown the errors that kept the core from properly loading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
